Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35679 )
Change subject: supermicro/x11-lga1151/gpio: 4/5 Convert field macros to PAD_CFG ......................................................................
Patch Set 10:
(1 comment)
Thanks for the review
https://review.coreboot.org/c/coreboot/+/35679/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35679/10//COMMIT_MSG@18 PS10, Line 18: Tested with BUILD_TIMELESS=1
I'm surprised this passes because the reset values are wrong before patch 5/5
This means that this test includes the following steps: 1) git am CB:42918 (3/5) 2) make BUILD_TIMELESS=1 3) cp build/coreboot.rom ../coreboot.rom 4) git am CB:35679 (4/5) 5) make BUILD_TIMELESS=1 6) diff build/coreboot.rom ../coreboot.rom - no differences
other patches are not related to this.
I make all the corrections for converting to target PAD_CFG macros only in patches 2/5 and 3/5. It’s easier to check patches with a lot of changes. It’s easier to review.
I am testing intelp2m in this patchset. After all the errors have been fixed in this utility, instead of a large patchset, you can use one commit to convert to PAD_CFG().