Thanks for the review
View Change
1 comment:
Commit Message:
Patch Set #10, Line 18: Tested with BUILD_TIMELESS=1
I'm surprised this passes because the reset values are wrong before patch 5/5
This means that this test includes the following steps:
1) git am CB:42918 (3/5)
2) make BUILD_TIMELESS=1
3) cp build/coreboot.rom ../coreboot.rom
4) git am CB:35679 (4/5)
5) make BUILD_TIMELESS=1
6) diff build/coreboot.rom ../coreboot.rom - no differences
other patches are not related to this.
I make all the corrections for converting to target PAD_CFG macros only in patches 2/5 and 3/5. It’s easier to check patches with a lot of changes. It’s easier to review.
I am testing intelp2m in this patchset. After all the errors have been fixed in this utility, instead of a large patchset, you can use one commit to convert to PAD_CFG().
To view, visit change 35679. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idad7536854d4b1ae7dcf7934e81de438478fe059
Gerrit-Change-Number: 35679
Gerrit-PatchSet: 10
Gerrit-Owner: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 06 Jul 2020 10:22:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment