[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/ibexpeak: Use SOUTHBRIDGE_INTEL_COMMON_PMCLIB

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32316 )

Change subject: sb/intel/ibexpeak: Use SOUTHBRIDGE_INTEL_COMMON_PMCLIB
......................................................................

Patch Set 2: Code-Review-2

(1 comment)

https://review.coreboot.org/#/c/32316/2/src/mainboard/lenovo/x201/romstage.c 
File src/mainboard/lenovo/x201/romstage.c:

https://review.coreboot.org/#/c/32316/2/src/mainboard/lenovo/x201/romstage.c... 
PS2, Line 266: 
             : 
             : 
             : 
             : 
             : 
             :
> raminit needs this, which is why it was cleared so late.

SLP_TYPE really needs to be cleared after intel_early_me_status is run. If done before it hangs during the raminit on a non-trivial place. So I guess the common code code cannot use at all...

Probably worth it to document it here, for future reference.