Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32316 ) Change subject: sb/intel/ibexpeak: Use SOUTHBRIDGE_INTEL_COMMON_PMCLIB ...................................................................... Patch Set 2: Code-Review-2 (1 comment) https://review.coreboot.org/#/c/32316/2/src/mainboard/lenovo/x201/romstage.c File src/mainboard/lenovo/x201/romstage.c: https://review.coreboot.org/#/c/32316/2/src/mainboard/lenovo/x201/romstage.c... PS2, Line 266: : : : : : :
raminit needs this, which is why it was cleared so late. SLP_TYPE really needs to be cleared after intel_early_me_status is run. If done before it hangs during the raminit on a non-trivial place. So I guess the common code code cannot use at all...
Probably worth it to document it here, for future reference. -- To view, visit https://review.coreboot.org/c/coreboot/+/32316 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I766a3f4206e6605e6b7bb9a1ff0b2deb6721eb77 Gerrit-Change-Number: 32316 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Sun, 14 Apr 2019 19:49:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz> Gerrit-MessageType: comment