Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40303 )
Change subject: mb/google/octopus/variants/bobba: Disable XHCI LFPS power management ......................................................................
Patch Set 8:
(5 comments)
Please remember to mark comments "Done" when they're done. That way the commit is marked unblocked ("All-Comments-Resolved" becomes green)
https://review.coreboot.org/c/coreboot/+/40303/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40303/1//COMMIT_MSG@9 PS1, Line 9: Disable XHCI LFPS power management.
There is a issue about LTE module lost which discussed in b:/146768983, Intel provide the solution c […]
Done
https://review.coreboot.org/c/coreboot/+/40303/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40303/3//COMMIT_MSG@9 PS3, Line 9: will
Thanks
Done
https://review.coreboot.org/c/coreboot/+/40303/3//COMMIT_MSG@9 PS3, Line 9: work around
Thanks
Done
https://review.coreboot.org/c/coreboot/+/40303/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40303/6//COMMIT_MSG@19 PS6, Line 19: BRANCH=None
it should be octopus, Thanks
Done
https://review.coreboot.org/c/coreboot/+/40303/7/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/bobba/variant.c:
https://review.coreboot.org/c/coreboot/+/40303/7/src/mainboard/google/octopu... PS7, Line 95: case 44:
agree, it is more clearly to understand this change is specific for LTE sku. […]
Done