Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 )
Change subject: mb/apple: Add MacBook Pro 8,1 support ......................................................................
Patch Set 13:
(18 comments)
https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... File Documentation/mainboard/apple/macbookpro8_1.md:
https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... PS11, Line 32: 00000000:00000fff fd
Yes.
Ack
https://review.coreboot.org/c/coreboot/+/33151/11/Documentation/mainboard/ap... PS11, Line 57: - Thunderbolt : - FireWire
Yes.
Ack, good enough
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... File src/mainboard/apple/macbookpro8_1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 102: device pci 01.1 on
Was added by autoport. Usually discrete graphics. Removed.
Ah, it's the result of bifurcating the PEG port. if PEG is unused, then it can be removed
https://review.coreboot.org/c/coreboot/+/33151/8/src/mainboard/apple/macbook... PS8, Line 105: device pci 1a.7 on
No idea. I don't see any issues after removing.
Doesn't it show up in lspci? It looks like some USB controller device, but it's weird that it appears here...
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 60: Audio Audio
Of course it's stereo!
:^)
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 31: 0x0 0
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/early_init.c:
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 30: Hub
This is what schematics says. And I don't see it routed to any OC# pin, or I'm stupid.
<rant> OF COURSE, ONLY APPLE would use DISCRETE USB HUBS instead of the USB ports on the PCH! </rant>
This means that the FAULT1# and FAULT2# signals coming out of U4600 (TPS2561DR) only go to these SMSC hubs (USB2514, USB2514B or USX2513B), which would handle the condition. So yes, no PCH OC# pin is actually used as such.
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 30: Analog
This is just a copy pasta that is used across the boards. […]
You only need to keep Internal and the DP/HDMI groups, as per schematics.
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/gpio.c:
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 30: gpio9 This is OC5#, but it's used as a GPIO (SDCONN_STATE_CHANGE)
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 31: gpio10 This is OC6#, but it's used as a GPIO (PCH_GPIO10_OC6_L)
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 35: gpio14 This is OC7#, but it's used as a GPIO (PCH_GPIO14_OC7_L)
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 74: GPIO_DIR_INPUT This should be an output in order to activate the SATA redriver U4510 (PS8521A)
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 115: gpio40 This is OC1#, but it's used as a GPIO (USB_HUB_SOFT_RESET_L)
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 116: gpio41 This is OC2#, but it's used as a GPIO (SDCONN_STATE_RST_L)
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 117: gpio42 This is OC3#, but it's used as a GPIO (ENET_PWR_EN)
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 118: gpio43 This is OC4#, but it's used as a GPIO (PCH_GPIO43_OC4_L)
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 134: gpio59 This is OC0#, but it's used as a GPIO (AP_PWR_EN)
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 161: GPIO_DIR_INPUT Schematics suggest that this should be an output, but there's a pull-up resistor already, so it doesn't really matter much.