Patch Set #11, Line 32:
Ack, good enough
Patch Set #8, Line 102:
device pci 01.1 on
Was added by autoport. Usually discrete graphics. Removed.
Ah, it's the result of bifurcating the PEG port. if PEG is unused, then it can be removed
Patch Set #8, Line 105:
device pci 1a.7 on
No idea. I don't see any issues after removing.
Doesn't it show up in lspci? It looks like some USB controller device, but it's weird that it appears here...
Patch Set #11, Line 60:
Of course it's stereo!
This is what schematics says. And I don't see it routed to any OC# pin, or I'm stupid.
<rant> OF COURSE, ONLY APPLE would use DISCRETE USB HUBS instead of the USB ports on the PCH! </rant>
This means that the FAULT1# and FAULT2# signals coming out of U4600 (TPS2561DR) only go to these SMSC hubs (USB2514, USB2514B or USX2513B), which would handle the condition. So yes, no PCH OC# pin is actually used as such.
Patch Set #11, Line 30:
This is just a copy pasta that is used across the boards. […]
You only need to keep Internal and the DP/HDMI groups, as per schematics.
Patch Set #13, Line 30:
This is OC5#, but it's used as a GPIO (SDCONN_STATE_CHANGE)
Patch Set #13, Line 31:
This is OC6#, but it's used as a GPIO (PCH_GPIO10_OC6_L)
Patch Set #13, Line 35:
This is OC7#, but it's used as a GPIO (PCH_GPIO14_OC7_L)
Patch Set #13, Line 74:
This should be an output in order to activate the SATA redriver U4510 (PS8521A)
Patch Set #13, Line 115:
This is OC1#, but it's used as a GPIO (USB_HUB_SOFT_RESET_L)
Patch Set #13, Line 116:
This is OC2#, but it's used as a GPIO (SDCONN_STATE_RST_L)
Patch Set #13, Line 117:
This is OC3#, but it's used as a GPIO (ENET_PWR_EN)
Patch Set #13, Line 118:
This is OC4#, but it's used as a GPIO (PCH_GPIO43_OC4_L)
Patch Set #13, Line 134:
This is OC0#, but it's used as a GPIO (AP_PWR_EN)
Patch Set #13, Line 161:
Schematics suggest that this should be an output, but there's a pull-up resistor already, so it doesn't really matter much.
To view, visit change 33151. To unsubscribe, or for help writing mail filters, visit settings.