Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33236 )
Change subject: src/cpu/x86 STM Support ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/#/c/33236/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33236/1//COMMIT_MSG@4 PS1, Line 4: EugeneDMyers Eugene D Myers
git commit --amend --author="Eugene D Myers cedarhouse1@comcast.net"
https://review.coreboot.org/#/c/33236/1//COMMIT_MSG@7 PS1, Line 7: src/cpu/x86 STM Support Please use:
cpu/x86: Add STM support
See `git log --oneline` how summaries should be done.
https://review.coreboot.org/#/c/33236/1//COMMIT_MSG@9 PS1, Line 9: STM initialization Please elaborate.
https://review.coreboot.org/#/c/33236/1//COMMIT_MSG@11 PS1, Line 11: Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Please add your Signed-off-by line below.
https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@1047 PS1, Line 1047: * that require 32k alignment of the save state on 32K boundries.*/ Please add a space before `*/`.
https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@1044 PS1, Line 1044: /* Currently, the CPU SMM save state size is based on a simplistic : * algorithm. (set it to 1K) : * note: In the future, this will need to handle newer x86 processors : * that require 32k alignment of the save state on 32K boundries.*/ Please see the coding style about how to format multi-line comments.
/* * … * /
or for concise style:
/* … … */