Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33250 )
Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature
......................................................................
Patch Set 6:
Are you still planning to address the mixed comment style in one line issue? That's the only reason why I'm here a bit hesitant to +2 the patch; otherwise it looks good to me
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33250
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic356af269e381bd5310d9be057bc16f9d5186934
Gerrit-Change-Number: 33250
Gerrit-PatchSet: 6
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 02 Jul 2019 12:26:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment