build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 51:
(64 comments)
File csb_patcher.sh:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/309ede9c_3755af37 PS51, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/9983e6f2_89db6758 PS51, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/300e3ec2_3bcf1005 PS51, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/40d6493f_775b3b20 PS51, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/01f5d8a3_fc52c4df PS51, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/f904410f_7e5cefa3 PS51, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/52e39fae_9b7b7b9d PS51, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/e89d6999_671416f9 PS51, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/7db234a1_56d8b67a PS51, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/9e8434ca_16edd36c PS51, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/52a84025_2d8554fe PS51, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/42e05d74_8d44d9b9 PS51, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/4090714a_bea84562 PS51, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/8e5439db_f43d276f PS51, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/6370ed24_12582d49 PS51, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/a29cda79_e8ebd146 PS51, Line 315: floppy_verifier "fiwix" "9ec69b7b1a7554ff1aad784304c3926cad69e95abcac1f8a846a7f6251e25fd9" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/761127bc_acc3cae1 PS51, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/7ec400d1_3902828a PS51, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/3c47354c_82fbff68 PS51, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/bb67c5cd_3311c815 PS51, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/f092a34d_01379b38 PS51, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/2f219ec5_fdd46728 PS51, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/5c72efeb_6b6d2041 PS51, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/0e88bed4_25c8bccd PS51, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/24116d20_27fb6297 PS51, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/f0c4ba74_f9c00c78 PS51, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/56443c24_fcf3608f PS51, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/82704b89_5eabf7b0 PS51, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/36e1e353_6c968a11 PS51, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/d6d88627_095ae1b0 PS51, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/ad83e878_f30209f9 PS51, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/2da1a75d_ef8a24c1 PS51, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/b9822a55_eb0b9bf1 PS51, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/0a6c23ec_2673bd22 PS51, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/ef905bbb_10d93e26 PS51, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/a4f6ef69_12c2f744 PS51, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/9dd67e53_23fe4f88 PS51, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/40ed0364_56dcd5ea PS51, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/700d608f_61133fcc PS51, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/7dc4d4de_aed318d1 PS51, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/47b241b1_2c4018a2 PS51, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/f9ad1ad0_4526cc3b PS51, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/3cd36ae4_d119769f PS51, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/e7716ddd_17220ebe PS51, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/08dad579_0549e56c PS51, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/7315ad5c_64c98641 PS51, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/f9bad96c_63bcda53 PS51, Line 732: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/31f27821_6bcc786c PS51, Line 734: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/21bd7c0b_f5c109a9 PS51, Line 749: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/3e4389d7_6ebcec08 PS51, Line 751: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/f32765e4_1776d1e0 PS51, Line 757: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/ff1fa9a6_508332e1 PS51, Line 773: csb_patcher "dgpu" "39873" "11" "2dcdeec" "a7c72231cf29eccfcabdf286d7cdf3cff097d302b2a981d45d9fda34357bb95c" "$1" "G505S " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/ac324a89_89dc76b9 PS51, Line 778: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/f9674ee0_d63947d0 PS51, Line 783: csb_patcher "irq" "48427" "9" "1bf54c4" "c5f7dd4acd75c6075a692ef7f33fcffdf65ad2dbef8eb538f10174f39d976adc" "$1" "AMD good " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/b8add7b4_f42d7809 PS51, Line 788: csb_patcher "seabios" "32351" "15" "c4fc787" "b15163a492215c3155e3029415bf07a4514d6c02dd393ad09148d2d4adc17657" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/a4c4b60c_27b26846 PS51, Line 793: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/00b80cc0_094594e0 PS51, Line 798: csb_patcher "config.lenovo_g505s" "32352" "37" "a90256b" "ae7a0f2097ec71b215c421df695fc5adc021636240810b0b0a139ae41f975272" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/bdbb1088_a81f65e3 PS51, Line 803: csb_patcher "config.asus_am1i-a" "33800" "24" "7aa38bc" "f0522955c9394e58e9e10f1d7dabcc5f8c643e7af548cefe5bc4856cf754a9e9" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/e85ff2f6_d736648c PS51, Line 808: csb_patcher "config.asus_a88xm-e" "39900" "11" "00eb676" "ab89fcd3c01e657f36c5845af0921d080209c06ce3077635bf53a56408ddb18d" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/d5717f39_0fc6c252 PS51, Line 815: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/dc460649_2ee50366 PS51, Line 818: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/7046c2af_1d207106 PS51, Line 871: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/e1cce3d5_2e7eb640 PS51, Line 872: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/c3332761_51150467 PS51, Line 894: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters