Xi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44700 )
Change subject: soc/mediatek/mt8192: Do dramc init settings ......................................................................
Patch Set 43:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44700/43/src/soc/mediatek/mt8192/dr... File src/soc/mediatek/mt8192/dramc_pi_main.c:
https://review.coreboot.org/c/coreboot/+/44700/43/src/soc/mediatek/mt8192/dr... PS43, Line 53:
Maybe no need for the extra blank line
Actually, we want to seperate the init and calibration codes using the blank~
https://review.coreboot.org/c/coreboot/+/44700/43/src/soc/mediatek/mt8192/dr... File src/soc/mediatek/mt8192/dramc_utility.c:
https://review.coreboot.org/c/coreboot/+/44700/43/src/soc/mediatek/mt8192/dr... PS43, Line 138: struct dfs_frequency_table shuffle = freq_shuffle_table[k_shu];
Use a pointer: […]
Ack
https://review.coreboot.org/c/coreboot/+/44700/43/src/soc/mediatek/mt8192/dr... PS43, Line 154: use fsp
Just "fsp"
Ack