Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/32134/7/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/32134/7/src/mainboard/google/hatch/variants/...
PS7, Line 248: 30
Is this the lowest value that works? Does it fail with 10ms? or 11ms?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32134
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib204e6b77b87ba6c775cf38e572476dd9eb37d1d
Gerrit-Change-Number: 32134
Gerrit-PatchSet: 7
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 02 Apr 2019 04:08:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment