[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer/halvor: Update settings for audio function

[Frank Wu (Code Review)]

Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44409 )

Change subject: mb/google/volteer/halvor: Update settings for audio function
......................................................................

Patch Set 5:

(1 comment)
> Patch Set 4:
>
> Please remove the gpio.c change. We left that in the fw_config.c already.

The gpio pins about audio are both configured in volteer/gpio.c and fw_config.c.
In my point of view, they are fine to configure in halvor/gpio.c.

Ref about GPP_A23 in volteer:
volteer/gpio.c:
https://github.com/coreboot/coreboot/blob/master/src/mainboard/google/voltee...
fw_config.c:
https://github.com/coreboot/coreboot/blob/master/src/mainboard/google/voltee...

https://review.coreboot.org/c/coreboot/+/44409/4/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/gpio.c:

https://review.coreboot.org/c/coreboot/+/44409/4/src/mainboard/google/voltee... 
PS4, Line 58: 	/* C16 : I2C0_SDA ==> PCH_I2C0_1V8_AUDIO_SDA */
> Maybe just leave I2C setting here.

Done