Patch Set 4:

Please remove the gpio.c change. We left that in the fw_config.c already.

The gpio pins about audio are both configured in volteer/gpio.c and fw_config.c.
In my point of view, they are fine to configure in halvor/gpio.c.

Ref about GPP_A23 in volteer:
volteer/gpio.c:
https://github.com/coreboot/coreboot/blob/master/src/mainboard/google/volteer/variants/volteer/gpio.c#L30
fw_config.c:
https://github.com/coreboot/coreboot/blob/master/src/mainboard/google/volteer/fw_config.c#L37

View Change

1 comment:

• File src/mainboard/google/volteer/variants/halvor/gpio.c:

  • Patch Set #4, Line 58: /* C16 : I2C0_SDA ==> PCH_I2C0_1V8_AUDIO_SDA */

    Maybe just leave I2C setting here.

    Done

To view, visit change 44409. To unsubscribe, or for help writing mail filters, visit settings.