[coreboot-gerrit] [S] Change in coreboot[master]: amdfwtool:combo: Move the filling of field "lookup" into function

[Fred Reitberger (Code Review)]

Fred Reitberger has submitted this change. ( https://review.coreboot.org/c/coreboot/+/66853 )

Change subject: amdfwtool:combo: Move the filling of field "lookup" into function
......................................................................

amdfwtool:combo: Move the filling of field "lookup" into function

This filling does not need to be done separately.

Change-Id: I53051349923dce40f4fc3f747ab41a93a3798823
Signed-off-by: Zheng Bao 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66853
Tested-by: build bot (Jenkins) 
Reviewed-by: Fred Reitberger 
---
M util/amdfwtool/amdfwtool.c
1 file changed, 17 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Fred Reitberger: Looks good to me, approved

diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c
index 0d5acee..19a9438 100644
--- a/util/amdfwtool/amdfwtool.c
+++ b/util/amdfwtool/amdfwtool.c
@@ -632,8 +632,9 @@

switch (cookie) {
    case PSP2_COOKIE:
-		/* caller is responsible for lookup mode */
    	cdir->header.cookie = cookie;
+		/* lookup mode is hardcoded for now. */
+		cdir->header.lookup = 1;
    	cdir->header.num_entries = count;
    	cdir->header.reserved[0] = 0;
    	cdir->header.reserved[1] = 0;
@@ -2604,7 +2605,6 @@
    	combo_dir->entries[0].lvl2_addr =
    		BUFF_TO_RUN_MODE(ctx, pspdir, AMD_ADDR_REL_BIOS);

-		combo_dir->header.lookup = 1;
    	fill_dir_header(combo_dir, 1, PSP2_COOKIE, &ctx);
    }