Fred Reitberger submitted this change.

View Change


Approvals: build bot (Jenkins): Verified Fred Reitberger: Looks good to me, approved
amdfwtool:combo: Move the filling of field "lookup" into function

This filling does not need to be done separately.

Change-Id: I53051349923dce40f4fc3f747ab41a93a3798823
Signed-off-by: Zheng Bao <fishbaozi@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66853
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
---
M util/amdfwtool/amdfwtool.c
1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c
index 0d5acee..19a9438 100644
--- a/util/amdfwtool/amdfwtool.c
+++ b/util/amdfwtool/amdfwtool.c
@@ -632,8 +632,9 @@

switch (cookie) {
case PSP2_COOKIE:
- /* caller is responsible for lookup mode */
cdir->header.cookie = cookie;
+ /* lookup mode is hardcoded for now. */
+ cdir->header.lookup = 1;
cdir->header.num_entries = count;
cdir->header.reserved[0] = 0;
cdir->header.reserved[1] = 0;
@@ -2604,7 +2605,6 @@
combo_dir->entries[0].lvl2_addr =
BUFF_TO_RUN_MODE(ctx, pspdir, AMD_ADDR_REL_BIOS);

- combo_dir->header.lookup = 1;
fill_dir_header(combo_dir, 1, PSP2_COOKIE, &ctx);
}


To view, visit change 66853. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53051349923dce40f4fc3f747ab41a93a3798823
Gerrit-Change-Number: 66853
Gerrit-PatchSet: 10
Gerrit-Owner: Bao Zheng <fishbaozi@gmail.com>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred@gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged