Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38624 )
Change subject: soc/intel/tigerlake: Configure TCSS setting ......................................................................
Patch Set 2:
(8 comments)
https://review.coreboot.org/c/coreboot/+/38624/1/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/38624/1/src/soc/intel/tigerlake/chi... PS1, Line 222: uint8_t TcssXhciEn;
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/38624/1/src/soc/intel/tigerlake/chi... PS1, Line 222: uint8_t TcssXhciEn;
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38624/1/src/soc/intel/tigerlake/chi... PS1, Line 223: uint8_t TcssXdciEn;
code indent should use tabs where possible
Ack
https://review.coreboot.org/c/coreboot/+/38624/1/src/soc/intel/tigerlake/chi... PS1, Line 223: uint8_t TcssXdciEn;
please, no spaces at the start of a line
Ack
https://review.coreboot.org/c/coreboot/+/38624/1/src/soc/intel/tigerlake/chi... PS1, Line 228: * value: 1 - controlled by iom, 0 - controled by retimer
'controled' may be misspelled - perhaps 'controlled'?
Ack
https://review.coreboot.org/c/coreboot/+/38624/1/src/soc/intel/tigerlake/chi... PS1, Line 228: * value: 1 - controlled by iom, 0 - controled by retimer
please, no space before tabs
Ack
https://review.coreboot.org/c/coreboot/+/38624/1/src/soc/intel/tigerlake/chi... PS1, Line 230: * value: 0 - not swapped , 1 - swapped
please, no space before tabs
Ack
https://review.coreboot.org/c/coreboot/+/38624/1/src/soc/intel/tigerlake/chi... PS1, Line 235: /*
trailing whitespace
Ack