View Change

8 comments:

• File src/soc/intel/tigerlake/chip.h:

  • Patch Set #1, Line 222: uint8_t TcssXhciEn;

    code indent should use tabs where possible

    Ack

  • Patch Set #1, Line 222: uint8_t TcssXhciEn;

    please, no spaces at the start of a line

    Ack

  • Patch Set #1, Line 223: uint8_t TcssXdciEn;

    code indent should use tabs where possible

    Ack

  • Patch Set #1, Line 223: uint8_t TcssXdciEn;

    please, no spaces at the start of a line

    Ack

  • Patch Set #1, Line 228: * value: 1 - controlled by iom, 0 - controled by retimer

    'controled' may be misspelled - perhaps 'controlled'?

    Ack

  • Patch Set #1, Line 228: * value: 1 - controlled by iom, 0 - controled by retimer

    please, no space before tabs

    Ack

  • Patch Set #1, Line 230: * value: 0 - not swapped , 1 - swapped

    please, no space before tabs

    Ack

  • Patch Set #1, Line 235: /*

    trailing whitespace

    Ack

To view, visit change 38624. To unsubscribe, or for help writing mail filters, visit settings.