Attention is currently required from: Paul Menzel, Angel Pons. Iru Cai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46832 ) Change subject: autoport: Add Broadwell SoC support ...................................................................... Patch Set 10: (3 comments) File util/autoport/wildcatpoint.go: https://review.coreboot.org/c/coreboot/+/46832/comment/612ede10_77200b6f PS9, Line 43: if bdw.variant == CORE_M { : nPorts = 10 : } else { : nPorts = 8 : }
Where does this information come from? Mobile 5th Generation Intel Core Processor Family I/O, Intel Core M Processor Family I/O, Mobile Intel Pentium Processor Family I/O, and Mobile Intel Celeron Processor Family I/O Datasheet (330837-004), 1.3 SKU Definition.
Table 1-2 (Mobile 5th Generation Intel Core Processor Family I/O, Mobile Intel Pentium Processor Family I/O, and Intel Celeron Processor Family I/O SKUs (U-Processor Line)) says U-processor has 8 USB ports. Table 1-4 (Intel Core M Processor I/O Platform SKUs) says Core M has 10 USB ports. https://review.coreboot.org/c/coreboot/+/46832/comment/da6d236e_905a227d PS9, Line 237: "pcie_port_coalesce": "1",
Why enabled by default? I see many boards set this.
https://review.coreboot.org/c/coreboot/+/46832/comment/60e8b37a_3988dcea PS9, Line 287: Split from soc/intel/broadwell/acpi/platform.asl
Why? I see librem_bdw uses one broadwell/acpi/platform.asl, which is the combination of soc/intel/broadwell/acpi/device_nvs.asl, southbridge/intel/common/acpi/platform.asl, soc/intel/common/acpi/acpi_wake_source.asl, and empty _WAK and _PTS (which are generated in mainboard acpi/platform.asl).
I can see google/jecht has all these asl files except acpi_wake_source.asl. Comments are removed now. -- To view, visit https://review.coreboot.org/c/coreboot/+/46832 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62ab51b8a9c5873695bd7d75543c452ec422f11d Gerrit-Change-Number: 46832 Gerrit-PatchSet: 10 Gerrit-Owner: Iru Cai <mytbk920423@gmail.com> Gerrit-Reviewer: Iru Cai <mytbk920423@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Juanita Harvey <juanitalynn969@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Comment-Date: Wed, 29 Sep 2021 14:02:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment