Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 24:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35523/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35523/4//COMMIT_MSG@9 PS4, Line 9: Adds initial, rudimentary support for Acer Aspire VN7-572G. May not boot correctly or at all. For testing purposes only.
Sorry. […]
I'll assume so, unless notified otherwise.
https://review.coreboot.org/c/coreboot/+/35523/24/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/Kconfig:
https://review.coreboot.org/c/coreboot/+/35523/24/src/mainboard/acer/aspire_... PS24, Line 18: select NO_POST # This platform has no way to see POST codes so disable them by default.
Not that I personally use the option, but with this, one can't enable POST […]
What do you mean? Do you mean that someone with this device wouldn't be able to use POST codes if they had a way of viewing them, or do you mean that this breaks it across the tree?