[coreboot-gerrit] [M] Change in coreboot[main]: [RFC] region: Turn region_end() into an inclusive region_last()

[Jakub Czapiga (Code Review)]

Attention is currently required from: Jérémy Compostella, Nico Huber.

Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79946?usp=email )

Change subject: [RFC] region: Turn region_end() into an inclusive region_last()
......................................................................

Patch Set 5:

(2 comments)

File src/commonlib/include/commonlib/region.h:

https://review.coreboot.org/c/coreboot/+/79946/comment/87785f7d_f8abd7d7 :
PS5, Line 127: return region_offset(r) + region_sz(r) - 1;
Isn't overflow still possible here? Should 1 be subtracted from size first? So like that: `return region_offset(r) + (region_sz(r) - 1);`

File tests/commonlib/region-test.c:

https://review.coreboot.org/c/coreboot/+/79946/comment/38b55ffd_4a51dd25 :
PS5, Line 338: assert_true((uintptr_t)backing <= SIZE_MAX);
What is the purpose of this assert? `backing` is a buffer, not size. Shouldn't you use `size` here instead?