Attention is currently required from: Jérémy Compostella, Nico Huber.
2 comments:
File src/commonlib/include/commonlib/region.h:
Patch Set #5, Line 127: return region_offset(r) + region_sz(r) - 1;
Isn't overflow still possible here? Should 1 be subtracted from size first? So like that: `return region_offset(r) + (region_sz(r) - 1);`
File tests/commonlib/region-test.c:
Patch Set #5, Line 338: assert_true((uintptr_t)backing <= SIZE_MAX);
What is the purpose of this assert? `backing` is a buffer, not size. Shouldn't you use `size` here instead?
To view, visit change 79946. To unsubscribe, or for help writing mail filters, visit settings.