Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38777 )
Change subject: soc/intel/tigerlake: Add PMC mux control
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38777/10/src/soc/intel/tigerlake/ac...
File src/soc/intel/tigerlake/acpi/pmc.asl:
https://review.coreboot.org/c/coreboot/+/38777/10/src/soc/intel/tigerlake/ac...
PS10, Line 18: External (_SB.PCI0, DeviceObj)
I don't think this is required.
https://review.coreboot.org/c/coreboot/+/38777/10/src/soc/intel/tigerlake/ac...
PS10, Line 24: INTC1026
Where is the kernel side of the change that updates this HID? I still see INT34D2 in 5.4 kernel in chromium tree. Are you working on pushing an update for that as well?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38777
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00c5f929b2eea5de3f8eba794dbe9b36c8083c52
Gerrit-Change-Number: 38777
Gerrit-PatchSet: 10
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Divya Sasidharan
divya.s.sasidharan@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Caveh Jalali
caveh@chromium.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Mar 2020 19:48:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment