Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer/aspire_vn7_572g: Adds support for an Acer laptop ......................................................................
Patch Set 2:
(4 comments)
Just a little clean up..
https://review.coreboot.org/c/coreboot/+/35523/2/src/mainboard/acer/aspire_v... File src/mainboard/acer/aspire_vn7_572g/Kconfig:
https://review.coreboot.org/c/coreboot/+/35523/2/src/mainboard/acer/aspire_v... PS2, Line 11: select MAINBOARD_USES_FSP2_0 Not necessary, since it is selected by the SOC.
https://review.coreboot.org/c/coreboot/+/35523/2/src/mainboard/acer/aspire_v... PS2, Line 13: select MAINBOARD_HAS_LPC_TPM According to some Google results, it should have a TPM2. So please also select `MAINBOARD_HAS_TPM2`.
https://review.coreboot.org/c/coreboot/+/35523/2/src/mainboard/acer/aspire_v... PS2, Line 22: default "Acer" Not necessary, since this is set by the upper Kconfig file "src/mainboard/acer/Kconfig".
https://review.coreboot.org/c/coreboot/+/35523/2/src/mainboard/acer/aspire_v... PS2, Line 36: config DEVICETREE : string : default "devicetree.cb" Not necessary, since this is already the default.