Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32512 )
Change subject: google/krane: Add Panel TV101WUM-NL6 support. ......................................................................
Patch Set 13:
(3 comments)
Why are the delays that high? Could you quote the datasheet/specification there?
Did you format the new file using clang-format?
https://review.coreboot.org/#/c/32512/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32512/13//COMMIT_MSG@7 PS13, Line 7: google/krane: Add Panel TV101WUM-NL6 support. Please remove the dot/period at the end.
https://review.coreboot.org/#/c/32512/13/src/mainboard/google/kukui/panel_kr... File src/mainboard/google/kukui/panel_krane.c:
https://review.coreboot.org/#/c/32512/13/src/mainboard/google/kukui/panel_kr... PS13, Line 382: mdelay(20); Why is the delay that high?
https://review.coreboot.org/#/c/32512/13/src/mainboard/google/kukui/panel_kr... PS13, Line 391: mdelay(100); 100 ms?