Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32512 ) Change subject: google/krane: Add Panel TV101WUM-NL6 support. ...................................................................... Patch Set 13: (3 comments) Why are the delays that high? Could you quote the datasheet/specification there? Did you format the new file using clang-format? https://review.coreboot.org/#/c/32512/13//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/32512/13//COMMIT_MSG@7 PS13, Line 7: google/krane: Add Panel TV101WUM-NL6 support. Please remove the dot/period at the end. https://review.coreboot.org/#/c/32512/13/src/mainboard/google/kukui/panel_kr... File src/mainboard/google/kukui/panel_krane.c: https://review.coreboot.org/#/c/32512/13/src/mainboard/google/kukui/panel_kr... PS13, Line 382: mdelay(20); Why is the delay that high? https://review.coreboot.org/#/c/32512/13/src/mainboard/google/kukui/panel_kr... PS13, Line 391: mdelay(100); 100 ms? -- To view, visit https://review.coreboot.org/c/coreboot/+/32512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb6b2be6c2c571c09c781f4370d8c52612421823 Gerrit-Change-Number: 32512 Gerrit-PatchSet: 13 Gerrit-Owner: Kaka Ni <nigang@huaqin.corp-partner.google.com> Gerrit-Reviewer: Jerry Han <hanxu5@huaqin.corp-partner.google.com> Gerrit-Reviewer: Kaka Ni <nigang@huaqin.corp-partner.google.com> Gerrit-Reviewer: Kook Zhang <zhangbinbin@huaqin.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: jitao shi <jitao.shi@mediatek.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 02 Jun 2019 08:52:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment