Attention is currently required from: Dinesh Gehlot, Eric Lai, Jamie Chen, Kapil Porwal, Nick Vaccaro, SH Kim, Sumeet R Pawnikar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81614?usp=email )
Change subject: mb/google/brya/var/xol: Configure power limits by battery status
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/xol/ramstage.c:
https://review.coreboot.org/c/coreboot/+/81614/comment/e83edd29_4362b702 :
PS2, Line 28: get_soc_power_limit_config
this is already present inside baseboard/brya. why not leveraging the same ?
src/mainboard/google/brya/variants/baseboard/brya/ramstage.c:14:static struct soc_power_limits_config *get_soc_power_limit_config(void)
I don't see any need for redundant implementation across baseboard and variant
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81614?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5d71e9edde0ecbd7aaf316cd754a6ebcff9da77d
Gerrit-Change-Number: 81614
Gerrit-PatchSet: 2
Gerrit-Owner: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Jamie Chen
jamie.chen@intel.com
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 01 Apr 2024 06:36:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment