[M] Change in coreboot[main]: mb/google/brya/var/xol: Configure power limits by battery status

[Subrata Banik (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jamie Chen, Kapil Porwal, Nick Vaccaro, SH Kim, Sumeet R Pawnikar.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81614?usp=email )

Change subject: mb/google/brya/var/xol: Configure power limits by battery status
......................................................................


Patch Set 2:

(1 comment)

File src/mainboard/google/brya/variants/xol/ramstage.c:

https://review.coreboot.org/c/coreboot/+/81614/comment/e83edd29_4362b702 :
PS2, Line 28: get_soc_power_limit_config
this is already present inside baseboard/brya. why not leveraging the same ?

src/mainboard/google/brya/variants/baseboard/brya/ramstage.c:14:static struct soc_power_limits_config *get_soc_power_limit_config(void)

I don't see any need for redundant implementation across baseboard and variant



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/81614?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5d71e9edde0ecbd7aaf316cd754a6ebcff9da77d
Gerrit-Change-Number: 81614
Gerrit-PatchSet: 2
Gerrit-Owner: SH Kim <[e-mail]>
Gerrit-Reviewer: Dinesh Gehlot <[e-mail]>
Gerrit-Reviewer: Eric Lai <[e-mail]>
Gerrit-Reviewer: Jamie Chen <[e-mail]>
Gerrit-Reviewer: Kapil Porwal <[e-mail]>
Gerrit-Reviewer: Nick Vaccaro <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Sumeet R Pawnikar <[e-mail]>
Gerrit-Attention: Eric Lai <[e-mail]>
Gerrit-Attention: Jamie Chen <[e-mail]>
Gerrit-Attention: SH Kim <[e-mail]>
Gerrit-Attention: Kapil Porwal <[e-mail]>
Gerrit-Attention: Dinesh Gehlot <[e-mail]>
Gerrit-Attention: Sumeet R Pawnikar <[e-mail]>
Gerrit-Attention: Nick Vaccaro <[e-mail]>
Gerrit-Comment-Date: Mon, 01 Apr 2024 06:36:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment