CK HU has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43957 )
Change subject: soc/mediatek/mt8192: Initial commit ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43957/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43957/1//COMMIT_MSG@7 PS1, Line 7: soc/mediatek/mt8192: Initial commit
Please make it a statement by adding a verb (in imperative mood). Maybe: […]
I would like it to be: 'soc/mediatek/mt8192: Add address map, memlayout and Kconfig for MT8192 SoC' because this patch does not have any executable code in it.
https://review.coreboot.org/c/coreboot/+/43957/1//COMMIT_MSG@10 PS1, Line 10:
Please give more details about the device. […]
OK, this is similar to MT8183 and I would add more details.