View Change
2 comments:
Commit Message:
Patch Set #1, Line 7: soc/mediatek/mt8192: Initial commit
Please make it a statement by adding a verb (in imperative mood). Maybe: […]
I would like it to be: 'soc/mediatek/mt8192: Add address map, memlayout and Kconfig for MT8192 SoC' because this patch does not have any executable code in it.
Patch Set #1, Line 10:
Please give more details about the device. […]
OK, this is similar to MT8183 and I would add more details.
To view, visit change 43957. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e34c03a11a77ed98674ffd8eeddb20ef5fea89d
Gerrit-Change-Number: 43957
Gerrit-PatchSet: 1
Gerrit-Owner: CK HU <ck.hu@mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 28 Jul 2020 08:43:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment