Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36221 )
Change subject: Add configurable ramstage support for minimal PCI scanning ......................................................................
Patch Set 17:
(6 comments)
https://review.coreboot.org/c/coreboot/+/36221/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36221/8//COMMIT_MSG@25 PS8, Line 25: keyword to sconfig
it's intentional
Ack
https://review.coreboot.org/c/coreboot/+/36221/8/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/36221/8/src/Kconfig@344 PS8, Line 344: The minimal PCI scanning will only check those parts that are enabled : in the devicetree.cb. By convention none of those devices should be bridges.
I just blew it away, I did not see a need for this text.
Ack
https://review.coreboot.org/c/coreboot/+/36221/8/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/36221/8/src/device/pci_device.c@119... PS8, Line 1191: dev = pcidev_path_behind(bus, devfn);
Can you give links to reviews of these past "bikeshedded passes" because I don't remember reviewing […]
Ack
https://review.coreboot.org/c/coreboot/+/36221/8/util/sconfig/lex.yy.c_shipp... File util/sconfig/lex.yy.c_shipped:
https://review.coreboot.org/c/coreboot/+/36221/8/util/sconfig/lex.yy.c_shipp... PS8, Line 9: #define YY_FLEX_SUBMINOR_VERSION 4
Why increment it by 3?
Ack
https://review.coreboot.org/c/coreboot/+/36221/8/util/sconfig/sconfig.tab.c_... File util/sconfig/sconfig.tab.c_shipped:
https://review.coreboot.org/c/coreboot/+/36221/8/util/sconfig/sconfig.tab.c_... PS8, Line 112: #ifndef YY_YY_HOME_RMINNICH_PROJECTS_LINUXBOOT_COREBOOTNERF_GITHUBCOREBOOT_UTIL_SCONFIG_SCONFIG_TAB_H_SHIPPED_INCLUDED
this is a generated file. Not much to be done I think.
Ack
https://review.coreboot.org/c/coreboot/+/36221/8/util/sconfig/sconfig.tab.h_... File util/sconfig/sconfig.tab.h_shipped:
https://review.coreboot.org/c/coreboot/+/36221/8/util/sconfig/sconfig.tab.h_... PS8, Line 33: #ifndef YY_YY_HOME_RMINNICH_PROJECTS_LINUXBOOT_COREBOOTNERF_GITHUBCOREBOOT_UTIL_SCONFIG_SCONFIG_TAB_H_SHIPPED_INCLUDED
ditto :-)
Ack