6 comments:
Patch Set #8, Line 25: keyword to sconfig
it's intentional
Ack
The minimal PCI scanning will only check those parts that are enabled
in the devicetree.cb. By convention none of those devices should be bridges.
I just blew it away, I did not see a need for this text.
Ack
Patch Set #8, Line 1191: dev = pcidev_path_behind(bus, devfn);
Can you give links to reviews of these past "bikeshedded passes" because I don't remember reviewing […]
Ack
File util/sconfig/lex.yy.c_shipped:
Patch Set #8, Line 9: #define YY_FLEX_SUBMINOR_VERSION 4
Why increment it by 3?
Ack
File util/sconfig/sconfig.tab.c_shipped:
Patch Set #8, Line 112: #ifndef YY_YY_HOME_RMINNICH_PROJECTS_LINUXBOOT_COREBOOTNERF_GITHUBCOREBOOT_UTIL_SCONFIG_SCONFIG_TAB_H_SHIPPED_INCLUDED
this is a generated file. Not much to be done I think.
Ack
File util/sconfig/sconfig.tab.h_shipped:
Patch Set #8, Line 33: #ifndef YY_YY_HOME_RMINNICH_PROJECTS_LINUXBOOT_COREBOOTNERF_GITHUBCOREBOOT_UTIL_SCONFIG_SCONFIG_TAB_H_SHIPPED_INCLUDED
ditto :-)
Ack
To view, visit change 36221. To unsubscribe, or for help writing mail filters, visit settings.