Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33387 )
Change subject: mainboard/emulation/qemu-aarch64: Add new board for ARMv8
......................................................................
Patch Set 30:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33387/29/src/mainboard/emulation/qe...
File src/mainboard/emulation/qemu-aarch64/Kconfig:
https://review.coreboot.org/c/coreboot/+/33387/29/src/mainboard/emulation/qe...
PS29, Line 30: select
Remove the comment.
Done
https://review.coreboot.org/c/coreboot/+/33387/29/src/mainboard/emulation/qe...
PS29, Line 48: config DRAM_SIZE_MB
qemu supports more than 512MiB of DRAM on that board, doesn't it? […]
If DRAM_SIZR_MB is larger than 1024 with "-m 2048M" as a QEMU option, an exception happens. I think that's because it tries to call read32()/write32() to beyond the QEMU memory size.
We can avoid the exception when we use "-m <large memory size>" on QEMU.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33387
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7c0831b1ecf08785b4ec8139d809bad9b3e1eec
Gerrit-Change-Number: 33387
Gerrit-PatchSet: 30
Gerrit-Owner: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: Asami Doi
d0iasm.pub@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 31 Jul 2019 10:28:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment