Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47154 )
Change subject: mb/google/dedede/variants/drawcia: Update Power Limit2 minimum value ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47154/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47154/1//COMMIT_MSG@7 PS1, Line 7: drawcia
In this patch, modified for drawcia and baseboard. Please, suggest the appropriate one here. […]
I just meant, it would be good to outline in the commit message all the boards that are impacted because of the change.
https://review.coreboot.org/c/coreboot/+/47154/1//COMMIT_MSG@9 PS1, Line 9: Update Power Limit2 minimum value to the same as maximum value.
The reason is that DTT (DPTF) does not throttle PL2, so need to set both max and min the same value. […]
Can you please add that to commit message?
Just curious: DTT does not throttle or do you want DTT to not throttle? Because if you set min different than max, then DTT would adjust PL2 within that range, right?
https://review.coreboot.org/c/coreboot/+/47154/1//COMMIT_MSG@13 PS1, Line 13: test
Using DTT GUI Tool verified these values. There should not be any difference in behavior.
Ack