View Change
3 comments:
Commit Message:
Patch Set #1, Line 7: drawcia
In this patch, modified for drawcia and baseboard. Please, suggest the appropriate one here. […]
I just meant, it would be good to outline in the commit message all the boards that are impacted because of the change.
Patch Set #1, Line 9: Update Power Limit2 minimum value to the same as maximum value.
The reason is that DTT (DPTF) does not throttle PL2, so need to set both max and min the same value. […]
Can you please add that to commit message?
Just curious: DTT does not throttle or do you want DTT to not throttle? Because if you set min different than max, then DTT would adjust PL2 within that range, right?
Patch Set #1, Line 13: test
Using DTT GUI Tool verified these values. There should not be any difference in behavior.
Ack
To view, visit change 47154. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ecf1ffcc7871192ebe18eb8c3c3fd3e1193721e
Gerrit-Change-Number: 47154
Gerrit-PatchSet: 1
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 03 Nov 2020 06:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Gerrit-MessageType: comment