Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 54:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35523/45//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35523/45//COMMIT_MSG@28 PS45, Line 28: - Remaining RAM slots (need other SPD addresses)
Um, RAM slots are a physical thing you can count. For example, a random board off the internets: […]
I know. I added a second RAM stick to this laptop once.
I remember slightly doubting the vendor firmware/DMI tables when I saw how there didn't seem to be any space for two more slots underneath the visible ones. If the board in that image only has two, it would seem to confirm my doubts.
I was anyways going to trust the schematics over the firmware, but this is one more indicator to that effect. And that vendor firmware can be unreliable.
https://review.coreboot.org/c/coreboot/+/35523/54/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35523/54/src/mainboard/acer/aspire_... PS54, Line 33: gpio_get(DGPU_PRESENT) Schematics: "H: UMA, L: OPTIMUS" This check might need to be inverted.