3 Feb
2021
3 Feb
'21
9 a.m.
Attention is currently required from: Patrick Rudolph, Arthur Heymans. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45699 )
Change subject: ironlake: Add support for x86_64 ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/cpu/x86/early_reset.S:
https://review.coreboot.org/c/coreboot/+/45699/comment/be530211_3efb8850 PS3, Line 12: .code32
This could be done in a separate CL...
It's normally the default and only the other changes trigger the need to spell it out explicitly. So yes, it could be done separately, but I think it's a wash.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45699
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60f2fccba357cb5fb5d85feb4ee8d02abfe6bc7e
Gerrit-Change-Number: 45699
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 03 Feb 2021 09:00:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment