Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45699 )
Change subject: ironlake: Add support for x86_64 ......................................................................
ironlake: Add support for x86_64
Allow to compile the experimental x86_64 code.
Tested on Lenovo Thinkpad T410. Works without issues.
Change-Id: I60f2fccba357cb5fb5d85feb4ee8d02abfe6bc7e Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/cpu/intel/microcode/microcode_asm.S M src/cpu/intel/model_2065x/Kconfig M src/cpu/x86/early_reset.S 3 files changed, 14 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/45699/1
diff --git a/src/cpu/intel/microcode/microcode_asm.S b/src/cpu/intel/microcode/microcode_asm.S index f02351a..5a8b907 100644 --- a/src/cpu/intel/microcode/microcode_asm.S +++ b/src/cpu/intel/microcode/microcode_asm.S @@ -45,6 +45,7 @@
.section .text .global update_bsp_microcode +.code32
update_bsp_microcode: /* Keep return address */ diff --git a/src/cpu/intel/model_2065x/Kconfig b/src/cpu/intel/model_2065x/Kconfig index 78cac30..19eeab0 100644 --- a/src/cpu/intel/model_2065x/Kconfig +++ b/src/cpu/intel/model_2065x/Kconfig @@ -3,12 +3,20 @@
if CPU_INTEL_MODEL_2065X
+config ARCH_EXP_X86_64 + bool "Experimental 64bit support" + default n + config CPU_SPECIFIC_OPTIONS def_bool y - select ARCH_BOOTBLOCK_X86_32 - select ARCH_VERSTAGE_X86_32 - select ARCH_ROMSTAGE_X86_32 - select ARCH_RAMSTAGE_X86_32 + select ARCH_BOOTBLOCK_X86_32 if !ARCH_EXP_X86_64 + select ARCH_VERSTAGE_X86_32 if !ARCH_EXP_X86_64 + select ARCH_ROMSTAGE_X86_32 if !ARCH_EXP_X86_64 + select ARCH_RAMSTAGE_X86_32 if !ARCH_EXP_X86_64 + select ARCH_BOOTBLOCK_X86_64 if ARCH_EXP_X86_64 + select ARCH_VERSTAGE_X86_64 if ARCH_EXP_X86_64 + select ARCH_ROMSTAGE_X86_64 if ARCH_EXP_X86_64 + select ARCH_RAMSTAGE_X86_64 if ARCH_EXP_X86_64 select SSE2 select UDELAY_TSC select TSC_MONOTONIC_TIMER diff --git a/src/cpu/x86/early_reset.S b/src/cpu/x86/early_reset.S index 6ce9d52..c6d0703 100644 --- a/src/cpu/x86/early_reset.S +++ b/src/cpu/x86/early_reset.S @@ -9,6 +9,7 @@
.section .text .global check_mtrr +.code32
check_mtrr: /* Use the MTRR default type MSR as a proxy for detecting INIT#.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45699 )
Change subject: ironlake: Add support for x86_64 ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45699/1/src/cpu/intel/model_2065x/K... File src/cpu/intel/model_2065x/Kconfig:
https://review.coreboot.org/c/coreboot/+/45699/1/src/cpu/intel/model_2065x/K... PS1, Line 12: select ARCH_BOOTBLOCK_X86_32 if !ARCH_EXP_X86_64 : select ARCH_VERSTAGE_X86_32 if !ARCH_EXP_X86_64 : select ARCH_ROMSTAGE_X86_32 if !ARCH_EXP_X86_64 : select ARCH_RAMSTAGE_X86_32 if !ARCH_EXP_X86_64 : select ARCH_BOOTBLOCK_X86_64 if ARCH_EXP_X86_64 : select ARCH_VERSTAGE_X86_64 if ARCH_EXP_X86_64 : select ARCH_ROMSTAGE_X86_64 if ARCH_EXP_X86_64 : select ARCH_RAMSTAGE_X86_64 if ARCH_EXP_X86_64 This could be more concise... CB:45730 and CB:45731 should help.
Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45699
to look at the new patch set (#2).
Change subject: ironlake: Add support for x86_64 ......................................................................
ironlake: Add support for x86_64
Allow to compile the experimental x86_64 code.
Tested on Lenovo Thinkpad T410. Hangs in SMM relocation. When skipped boots into GNU/Linux.
Change-Id: I60f2fccba357cb5fb5d85feb4ee8d02abfe6bc7e Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/cpu/intel/microcode/microcode_asm.S M src/cpu/intel/model_2065x/Kconfig M src/cpu/x86/early_reset.S 3 files changed, 8 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/45699/2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45699 )
Change subject: ironlake: Add support for x86_64 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45699/1/src/cpu/intel/model_2065x/K... File src/cpu/intel/model_2065x/Kconfig:
https://review.coreboot.org/c/coreboot/+/45699/1/src/cpu/intel/model_2065x/K... PS1, Line 12: select ARCH_BOOTBLOCK_X86_32 if !ARCH_EXP_X86_64 : select ARCH_VERSTAGE_X86_32 if !ARCH_EXP_X86_64 : select ARCH_ROMSTAGE_X86_32 if !ARCH_EXP_X86_64 : select ARCH_RAMSTAGE_X86_32 if !ARCH_EXP_X86_64 : select ARCH_BOOTBLOCK_X86_64 if ARCH_EXP_X86_64 : select ARCH_VERSTAGE_X86_64 if ARCH_EXP_X86_64 : select ARCH_ROMSTAGE_X86_64 if ARCH_EXP_X86_64 : select ARCH_RAMSTAGE_X86_64 if ARCH_EXP_X86_64
This could be more concise... CB:45730 and CB:45731 should help.
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45699 )
Change subject: ironlake: Add support for x86_64 ......................................................................
Patch Set 3: Code-Review+1
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45699 )
Change subject: ironlake: Add support for x86_64 ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45699/3/src/cpu/x86/early_reset.S File src/cpu/x86/early_reset.S:
https://review.coreboot.org/c/coreboot/+/45699/3/src/cpu/x86/early_reset.S@1... PS3, Line 12: .code32 This could be done in a separate CL...
Attention is currently required from: Patrick Rudolph, Arthur Heymans. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45699 )
Change subject: ironlake: Add support for x86_64 ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/cpu/x86/early_reset.S:
https://review.coreboot.org/c/coreboot/+/45699/comment/be530211_3efb8850 PS3, Line 12: .code32
This could be done in a separate CL...
It's normally the default and only the other changes trigger the need to spell it out explicitly. So yes, it could be done separately, but I think it's a wash.
Attention is currently required from: Patrick Rudolph. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45699 )
Change subject: ironlake: Add support for x86_64 ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3: needs rebase
Attention is currently required from: Patrick Rudolph. Hello build bot (Jenkins), Patrick Georgi, Angel Pons, Arthur Heymans, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45699
to look at the new patch set (#4).
Change subject: ironlake: Add support for x86_64 ......................................................................
ironlake: Add support for x86_64
Allow to compile the experimental x86_64 code.
Tested on Lenovo Thinkpad T410. Hangs in SMM relocation. When skipped boots into GNU/Linux.
Change-Id: I60f2fccba357cb5fb5d85feb4ee8d02abfe6bc7e Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/cpu/intel/model_2065x/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/45699/4
Attention is currently required from: Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45699 )
Change subject: ironlake: Add support for x86_64 ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/45699/comment/efbdcc27_70189b7c PS4, Line 12: Hangs in SMM relocation. Still true?
Attention is currently required from: Patrick Rudolph. Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45699 )
Change subject: ironlake: Add support for x86_64 ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45699 )
Change subject: ironlake: Add support for x86_64 ......................................................................
ironlake: Add support for x86_64
Allow to compile the experimental x86_64 code.
Tested on Lenovo Thinkpad T410. Hangs in SMM relocation. When skipped boots into GNU/Linux.
Change-Id: I60f2fccba357cb5fb5d85feb4ee8d02abfe6bc7e Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45699 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Christian Walter christian.walter@9elements.com --- M src/cpu/intel/model_2065x/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Christian Walter: Looks good to me, approved
diff --git a/src/cpu/intel/model_2065x/Kconfig b/src/cpu/intel/model_2065x/Kconfig index 731ea37..5ff809f 100644 --- a/src/cpu/intel/model_2065x/Kconfig +++ b/src/cpu/intel/model_2065x/Kconfig @@ -5,6 +5,7 @@
config CPU_SPECIFIC_OPTIONS def_bool y + select HAVE_EXP_X86_64_SUPPORT select ARCH_X86 select BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES select SSE2
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Christian Walter (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)