Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30767 )
Change subject: mb/asus/h61m-cs: Add ASUS H61M-CS
......................................................................
Patch Set 11: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/30767/10/src/mainboard/asus/h61m-cs/devicetr...
File src/mainboard/asus/h61m-cs/devicetree.cb:
https://review.coreboot.org/#/c/30767/10/src/mainboard/asus/h61m-cs/devicetr...
PS10, Line 60: device pci 1c.5 on # Realtek Gigabit NIC
when I set 1c.5 to off the ethernet stopped working. Also setting 1c. […]
Please try removing `pcie_port_coalesce = "1"` from the devicetree.
The coalescing isn't necessary, and maybe it's causing the issues.
With coalescing disabled, please check if lspci shows the Realtek NIC
under 1c.5, and whether 1c.4 still needs to be set to `on`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30767
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ed2077248a8d7123c728c790d9b81fe37956ed2
Gerrit-Change-Number: 30767
Gerrit-PatchSet: 11
Gerrit-Owner: Dev Master
realdevmaster64@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Dev Master
realdevmaster64@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 20 Jan 2019 13:40:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tristan Corrick
tristan@corrick.kiwi
Comment-In-Reply-To: Dev Master
realdevmaster64@gmail.com
Gerrit-MessageType: comment