Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37675 )
Change subject: drivers/intel/fsp2_0: honour FSP2_0_DISPLAY_LOGO Kconfig ......................................................................
Patch Set 1:
(1 comment)
Please don't use preprocessor guards unless really necessary. What exactly are you trying to fix?
https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... PS1, Line 60: #if (CONFIG(FSP2_0_DISPLAY_LOGO)) I think this should just be `if (CONFIG(FSP2_0_DISPLAY_LOGO))` without any preprocessor guards (Kconfig already takes care of the HAVE_FSP_GOP dependency, which should rather be RUN_FSP_GOP btw. no need to load the logo, if other means to initialize graphics are used). Garbage collection will remove the code here if the config is unset (otherwise we couldn't link, as `logo.c` is also guarded in the `Makefile.inc`).