Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38830 )
Change subject: nb/intel/sandybridge/acpi: Fix MMCONF size computation ......................................................................
nb/intel/sandybridge/acpi: Fix MMCONF size computation
Calculate the correct MMCONF size, which was only correct for 256MiB, but not for smaller values.
Tested on HP Z220: Fixes "Not using MMCONF" warning in dmesg.
Change-Id: I986681126637c28f6442ab7c34acea5bb58ea3d2 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38830 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Jonathan Kollasch jakllsch@kollasch.net --- M src/northbridge/intel/sandybridge/acpi/sandybridge.asl 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Jonathan Kollasch: Looks good to me, but someone else must approve Nico Huber: Looks good to me, approved
diff --git a/src/northbridge/intel/sandybridge/acpi/sandybridge.asl b/src/northbridge/intel/sandybridge/acpi/sandybridge.asl index 3181fc0..0670c7b 100644 --- a/src/northbridge/intel/sandybridge/acpi/sandybridge.asl +++ b/src/northbridge/intel/sandybridge/acpi/sandybridge.asl @@ -62,7 +62,7 @@ XBR0 = _SB.PCI0.MCHC.PXBR << 26
CreateDwordField (PDRS, ^PCIX._LEN, XSZ0) - XSZ0 = 0x10000000 << _SB.PCI0.MCHC.PXSZ + XSZ0 = 0x10000000 >> _SB.PCI0.MCHC.PXSZ
Return(PDRS) }