Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38830 )
Change subject: nb/intel/sandybridge/acpi: Fix MMCONF size computation ......................................................................
nb/intel/sandybridge/acpi: Fix MMCONF size computation
Calculate the correct MMCONF size, which was only correct for 256MiB, but not for smaller values.
Change-Id: I986681126637c28f6442ab7c34acea5bb58ea3d2 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/northbridge/intel/sandybridge/acpi/sandybridge.asl 1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/38830/1
diff --git a/src/northbridge/intel/sandybridge/acpi/sandybridge.asl b/src/northbridge/intel/sandybridge/acpi/sandybridge.asl index 3181fc0..cf17df0 100644 --- a/src/northbridge/intel/sandybridge/acpi/sandybridge.asl +++ b/src/northbridge/intel/sandybridge/acpi/sandybridge.asl @@ -62,7 +62,12 @@ XBR0 = _SB.PCI0.MCHC.PXBR << 26
CreateDwordField (PDRS, ^PCIX._LEN, XSZ0) - XSZ0 = 0x10000000 << _SB.PCI0.MCHC.PXSZ + If (_SB.PCI0.MCHC.PXSZ == 0) { + XSZ0 = 0x10000000 + } + If (_SB.PCI0.MCHC.PXSZ == 1) { + XSZ0 = 0x8000000 + }
Return(PDRS) }
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38830 )
Change subject: nb/intel/sandybridge/acpi: Fix MMCONF size computation ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38830/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/acpi/sandybridge.asl:
https://review.coreboot.org/c/coreboot/+/38830/1/src/northbridge/intel/sandy... PS1, Line 68: PXSZ It's a 2-bit value. Missing some cases.
Anyway, the correct operation seems to be a shift right instead of left, I'll try to confirm that.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38830 )
Change subject: nb/intel/sandybridge/acpi: Fix MMCONF size computation ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38830/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/acpi/sandybridge.asl:
https://review.coreboot.org/c/coreboot/+/38830/1/src/northbridge/intel/sandy... PS1, Line 68: PXSZ
It's a 2-bit value. Missing some cases. […]
`>>` seems correct and is what newer copies of the code do.
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38830
to look at the new patch set (#2).
Change subject: nb/intel/sandybridge/acpi: Fix MMCONF size computation ......................................................................
nb/intel/sandybridge/acpi: Fix MMCONF size computation
Calculate the correct MMCONF size, which was only correct for 256MiB, but not for smaller values.
Tested on HP Z220: Fixes "Not using MMCONG" warning in dmesg.
Change-Id: I986681126637c28f6442ab7c34acea5bb58ea3d2 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/northbridge/intel/sandybridge/acpi/sandybridge.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/38830/2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38830 )
Change subject: nb/intel/sandybridge/acpi: Fix MMCONF size computation ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38830/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/acpi/sandybridge.asl:
https://review.coreboot.org/c/coreboot/+/38830/1/src/northbridge/intel/sandy... PS1, Line 68: PXSZ
`>>` seems correct and is what newer copies of the code do.
good point
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38830
to look at the new patch set (#3).
Change subject: nb/intel/sandybridge/acpi: Fix MMCONF size computation ......................................................................
nb/intel/sandybridge/acpi: Fix MMCONF size computation
Calculate the correct MMCONF size, which was only correct for 256MiB, but not for smaller values.
Tested on HP Z220: Fixes "Not using MMCONF" warning in dmesg.
Change-Id: I986681126637c28f6442ab7c34acea5bb58ea3d2 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/northbridge/intel/sandybridge/acpi/sandybridge.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/38830/3
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38830 )
Change subject: nb/intel/sandybridge/acpi: Fix MMCONF size computation ......................................................................
Patch Set 3: Code-Review+2
Jonathan Kollasch has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38830 )
Change subject: nb/intel/sandybridge/acpi: Fix MMCONF size computation ......................................................................
Patch Set 3: Code-Review+1
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38830 )
Change subject: nb/intel/sandybridge/acpi: Fix MMCONF size computation ......................................................................
nb/intel/sandybridge/acpi: Fix MMCONF size computation
Calculate the correct MMCONF size, which was only correct for 256MiB, but not for smaller values.
Tested on HP Z220: Fixes "Not using MMCONF" warning in dmesg.
Change-Id: I986681126637c28f6442ab7c34acea5bb58ea3d2 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38830 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Jonathan Kollasch jakllsch@kollasch.net --- M src/northbridge/intel/sandybridge/acpi/sandybridge.asl 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Jonathan Kollasch: Looks good to me, but someone else must approve Nico Huber: Looks good to me, approved
diff --git a/src/northbridge/intel/sandybridge/acpi/sandybridge.asl b/src/northbridge/intel/sandybridge/acpi/sandybridge.asl index 3181fc0..0670c7b 100644 --- a/src/northbridge/intel/sandybridge/acpi/sandybridge.asl +++ b/src/northbridge/intel/sandybridge/acpi/sandybridge.asl @@ -62,7 +62,7 @@ XBR0 = _SB.PCI0.MCHC.PXBR << 26
CreateDwordField (PDRS, ^PCIX._LEN, XSZ0) - XSZ0 = 0x10000000 << _SB.PCI0.MCHC.PXSZ + XSZ0 = 0x10000000 >> _SB.PCI0.MCHC.PXSZ
Return(PDRS) }
-
Felix Held (Code Review) -
Jonathan Kollasch (Code Review)
-
Nico Huber (Code Review)
-
Patrick Rudolph (Code Review)