HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38347 )
Change subject: test ......................................................................
test
Change-Id: Ifaa0d1c79802872c1a822c1108d2a50bc60c8fd8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200110_iasl.patch D util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum 4 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/38347/1
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 6150011..9ebda18 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -54,7 +54,7 @@ GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.33.1 GDB_VERSION=8.3.1 -IASL_VERSION=20190703 +IASL_VERSION=20200110 PYTHON_VERSION=3.8.1 EXPAT_VERSION=2.2.9 # CLANG version number @@ -861,9 +861,9 @@ test "$UNAME" = "Cygwin" && HOST="_CYGWIN" HOST="$HOST" CFLAGS="$CFLAGS" \ OPT_CFLAGS="-O -D_FORTIFY_SOURCE=2 -D COREBOOT_TOOLCHAIN_VERSION='"coreboot toolchain v$CROSSGCC_VERSION $CROSSGCC_DATE"' " \ - $MAKE $JOBS CC="$(hostcc host)" iasl acpibin acpidump acpiexec acpihelp acpinames acpisrc acpixtract - rm -f "$DESTDIR$TARGETDIR/bin/{iasl,acpibin,acpidump,acpiexec,acpihelp,acpinames,acpisrc,acpixtract}" || touch "$RDIR/.failed" - cp bin/{iasl,acpibin,acpidump,acpiexec,acpihelp,acpinames,acpisrc,acpixtract} "$DESTDIR$TARGETDIR/bin" || touch "$RDIR/.failed" + $MAKE CC="$(hostcc host)" iasl || touch "$RDIR/.failed" + rm -f "$DESTDIR$TARGETDIR/bin/iasl" || touch "$RDIR/.failed" + cp bin/iasl "$DESTDIR$TARGETDIR/bin" || touch "$RDIR/.failed" }
build_LLVM() { diff --git a/util/crossgcc/patches/acpica-unix2-20190703_iasl.patch b/util/crossgcc/patches/acpica-unix2-20200110_iasl.patch similarity index 100% rename from util/crossgcc/patches/acpica-unix2-20190703_iasl.patch rename to util/crossgcc/patches/acpica-unix2-20200110_iasl.patch diff --git a/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum deleted file mode 100644 index 9a89796..0000000 --- a/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -c5594944f933265a53695204a0672d0808e4a580 tarballs/acpica-unix2-20190703.tar.gz diff --git a/util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum new file mode 100644 index 0000000..48c0a2f --- /dev/null +++ b/util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum @@ -0,0 +1 @@ +50c163d965aa2cbee9a3a5d9244d1a0d16c06ec0 tarballs/acpica-unix2-20200110.tar.gz
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38347
to look at the new patch set (#2).
Change subject: Test IASL ......................................................................
Test IASL
Changes: 20200110: https://acpica.org/node/176 20191213: https://acpica.org/node/175 20191018: https://acpica.org/node/174 20190816: https://acpica.org/node/172
Change-Id: Ifaa0d1c79802872c1a822c1108d2a50bc60c8fd8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200110_iasl.patch D util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum 4 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/38347/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38347
to look at the new patch set (#3).
Change subject: Test IASL ......................................................................
Test IASL
Changes: 20200110: https://acpica.org/node/176 20191213: https://acpica.org/node/175 20191018: https://acpica.org/node/174 20190816: https://acpica.org/node/172
Change-Id: Ifaa0d1c79802872c1a822c1108d2a50bc60c8fd8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/broadwell/acpi/serialio.asl M src/southbridge/intel/lynxpoint/acpi/serialio.asl M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200110_iasl.patch D util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum 6 files changed, 37 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/38347/3
HAOUAS Elyes has removed Patrick Rudolph from this change. ( https://review.coreboot.org/c/coreboot/+/38347 )
Change subject: Test IASL ......................................................................
Removed reviewer Patrick Rudolph.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38347
to look at the new patch set (#4).
Change subject: crossgcc: Upgrade IASL to 20200110 version ......................................................................
crossgcc: Upgrade IASL to 20200110 version
Changes: 20200110: https://acpica.org/node/176 20191213: https://acpica.org/node/175 20191018: https://acpica.org/node/174 20190816: https://acpica.org/node/172
Change-Id: Ifaa0d1c79802872c1a822c1108d2a50bc60c8fd8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200110_iasl.patch D util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum 4 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/38347/4
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38347 )
Change subject: crossgcc: Upgrade IASL to 20200110 version ......................................................................
Patch Set 9: Code-Review+2
Maybe file a bug and disable warning 3073 in Makefile.inc so we can get this merged? That's not making things any worse than they are now.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38347 )
Change subject: crossgcc: Upgrade IASL to 20200110 version ......................................................................
Patch Set 9: Code-Review+1
(1 comment)
Patch Set 9: Code-Review+2
Maybe file a bug and disable warning 3073 in Makefile.inc so we can get this merged? That's not making things any worse than they are now.
Sounds good
https://review.coreboot.org/c/coreboot/+/38347/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38347/9//COMMIT_MSG@7 PS9, Line 7: 20200110 version version 20200110
Hello Angel Pons, build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38347
to look at the new patch set (#10).
Change subject: crossgcc: Upgrade IASL to version 20200110 ......................................................................
crossgcc: Upgrade IASL to version 20200110
Changes: 20200110: https://acpica.org/node/176 20191213: https://acpica.org/node/175 20191018: https://acpica.org/node/174 20190816: https://acpica.org/node/172
Change-Id: Ifaa0d1c79802872c1a822c1108d2a50bc60c8fd8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200110_iasl.patch D util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum 4 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/38347/10
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38347 )
Change subject: crossgcc: Upgrade IASL to version 20200110 ......................................................................
Patch Set 10:
(1 comment)
Thx
https://review.coreboot.org/c/coreboot/+/38347/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38347/9//COMMIT_MSG@7 PS9, Line 7: 20200110 version
version 20200110
Done
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38347 )
Change subject: crossgcc: Upgrade IASL to version 20200110 ......................................................................
Patch Set 11: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38347 )
Change subject: crossgcc: Upgrade IASL to version 20200110 ......................................................................
Patch Set 11: Code-Review+1
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38347 )
Change subject: crossgcc: Upgrade IASL to version 20200110 ......................................................................
Patch Set 11: Code-Review+2
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38347 )
Change subject: crossgcc: Upgrade IASL to version 20200110 ......................................................................
crossgcc: Upgrade IASL to version 20200110
Changes: 20200110: https://acpica.org/node/176 20191213: https://acpica.org/node/175 20191018: https://acpica.org/node/174 20190816: https://acpica.org/node/172
Change-Id: Ifaa0d1c79802872c1a822c1108d2a50bc60c8fd8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38347 Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20200110_iasl.patch D util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum 4 files changed, 2 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Martin Roth: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index ab2ea89..150e616 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -54,11 +54,7 @@ GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.33.1 GDB_VERSION=8.3.1 - -# Conflicting use of _ADR and _HID in coreboot tree needs -# to be properly addressed before we can upgrade IASL version. -# Use IASL version 20190703 for now. -IASL_VERSION=20190703 +IASL_VERSION=20200110 PYTHON_VERSION=3.8.1 EXPAT_VERSION=2.2.9 # CLANG version number diff --git a/util/crossgcc/patches/acpica-unix2-20190703_iasl.patch b/util/crossgcc/patches/acpica-unix2-20200110_iasl.patch similarity index 100% rename from util/crossgcc/patches/acpica-unix2-20190703_iasl.patch rename to util/crossgcc/patches/acpica-unix2-20200110_iasl.patch diff --git a/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum deleted file mode 100644 index 9a89796..0000000 --- a/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -c5594944f933265a53695204a0672d0808e4a580 tarballs/acpica-unix2-20190703.tar.gz diff --git a/util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum new file mode 100644 index 0000000..48c0a2f --- /dev/null +++ b/util/crossgcc/sum/acpica-unix2-20200110.tar.gz.cksum @@ -0,0 +1 @@ +50c163d965aa2cbee9a3a5d9244d1a0d16c06ec0 tarballs/acpica-unix2-20200110.tar.gz
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38347 )
Change subject: crossgcc: Upgrade IASL to version 20200110 ......................................................................
Patch Set 12:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/559 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/558 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/557
Please note: This test is under development and might not be accurate at all!