build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43717 )
Change subject: payloads/libpayload/libc: uppgrade qsort.c to v1.18 ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/43717/4/payloads/libpayload/libc/qs... File payloads/libpayload/libc/qsort.c:
https://review.coreboot.org/c/coreboot/+/43717/4/payloads/libpayload/libc/qs... PS4, Line 103: case SWAPTYPE_LONG: { \ Possible switch case/default not preceded by break or fallthrough comment
https://review.coreboot.org/c/coreboot/+/43717/4/payloads/libpayload/libc/qs... PS4, Line 109: default: \ Possible switch case/default not preceded by break or fallthrough comment
https://review.coreboot.org/c/coreboot/+/43717/4/payloads/libpayload/libc/qs... PS4, Line 114: #define vecswap(a, b, n) if ((n) > 0) swapfunc(a, b, n, swaptype) Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
https://review.coreboot.org/c/coreboot/+/43717/4/payloads/libpayload/libc/qs... PS4, Line 126: int (*cmp)(const void *, const void *)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43717/4/payloads/libpayload/libc/qs... PS4, Line 132: loop: if (n < 7) { suspect code indent for conditional statements (0, 16)