View Change

5 comments:

• File payloads/libpayload/libc/qsort.c:

  • Patch Set #4, Line 103: case SWAPTYPE_LONG: { \

    Possible switch case/default not preceded by break or fallthrough comment

  • Patch Set #4, Line 109: default: \

    Possible switch case/default not preceded by break or fallthrough comment

  • Patch Set #4, Line 114: #define vecswap(a, b, n) if ((n) > 0) swapfunc(a, b, n, swaptype)

    Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects

  • Patch Set #4, Line 126: int (*cmp)(const void *, const void *))

    please, no spaces at the start of a line

  • Patch Set #4, Line 132: loop: if (n < 7) {

    suspect code indent for conditional statements (0, 16)

To view, visit change 43717. To unsubscribe, or for help writing mail filters, visit settings.