Attention is currently required from: Nico Huber, Eugene Myers, Benjamin Doron, Paul Menzel, Angel Pons, Michael Niewöhner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 191: Verified+1
(13 comments)
File src/mainboard/acer/aspire_vn7_572g/Kconfig:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134936): https://review.coreboot.org/c/coreboot/+/35523/comment/ef868d28_cfa0e371 PS191, Line 22: select NO_UART_ON_SUPERIO 'SUPERIO' may be misspelled - perhaps ''?
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134936): https://review.coreboot.org/c/coreboot/+/35523/comment/07c7745a_fef17365 PS191, Line 45: if (data_buffer <= (2017 / ADC_3V_10BIT_GRANULARITY_MAX)) { braces {} are not necessary for any arm of this statement
File src/mainboard/acer/aspire_vn7_572g/devicetree.cb:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134936): https://review.coreboot.org/c/coreboot/+/35523/comment/2ff22c77_47cb1528 PS191, Line 303: | LPC_IOE_EC_62_66 | LPC_IOE_SUPERIO_2E_2F | LPC_IOE_EC_4E_4F" # 82h-83h 'SUPERIO' may be misspelled - perhaps ''?
File src/mainboard/acer/aspire_vn7_572g/die.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134936): https://review.coreboot.org/c/coreboot/+/35523/comment/cec911a4_52fb039f PS191, Line 9: if (ENV_POSTCAR) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134936): https://review.coreboot.org/c/coreboot/+/35523/comment/317009aa_cc7c99de PS191, Line 29: if (!nhlt) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134936): https://review.coreboot.org/c/coreboot/+/35523/comment/1d9c693e_9e7c36a8 PS191, Line 37: if (nhlt_soc_add_dmic_array(nhlt, 1) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134936): https://review.coreboot.org/c/coreboot/+/35523/comment/0b3faf95_1049448f PS191, Line 42: if (nhlt_soc_add_dmic_array(nhlt, 2) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134936): https://review.coreboot.org/c/coreboot/+/35523/comment/566f0b63_d5ddf379 PS191, Line 48: if (end_addr != start_addr) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134936): https://review.coreboot.org/c/coreboot/+/35523/comment/84d431f3_85461e6a PS191, Line 61: if (CONFIG(INCLUDE_NHLT_BLOBS)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134936): https://review.coreboot.org/c/coreboot/+/35523/comment/b274d9a4_86b14aec PS191, Line 98: if (dat & 1) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134936): https://review.coreboot.org/c/coreboot/+/35523/comment/2d21da70_8556b8e2 PS191, Line 122: if (!(out_data & 2)) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134936): https://review.coreboot.org/c/coreboot/+/35523/comment/21287f36_1f1bdf9e PS191, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)
File src/mainboard/acer/aspire_vn7_572g/smihandler.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134936): https://review.coreboot.org/c/coreboot/+/35523/comment/06d394f5_dd0fe601 PS191, Line 159: if (gnvs) { braces {} are not necessary for single statement blocks