[coreboot-gerrit] Change in coreboot[master]: Add support for the 51nb X210

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32531 )

Change subject: Add support for the 51nb X210
......................................................................

Patch Set 28: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/32531/28/src/mainboard/51nb/x210/ro... 
File src/mainboard/51nb/x210/romstage.c:

https://review.coreboot.org/c/coreboot/+/32531/28/src/mainboard/51nb/x210/ro... 
PS28, Line 28: 	/* Rcomp resistor */
> Null check?

Not strictly required as the function is static and called in a way that it can't be NULL

https://review.coreboot.org/c/coreboot/+/32531/28/src/mainboard/51nb/x210/ro... 
PS28, Line 36: 	/* Rcomp target */
> See above

Not strictly required as the function is static and called in a way that it can't be NULL