Attention is currently required from: Anson Tseng, Karthik Ramasubramanian, Paul Menzel, Shou-Chieh Hsu.
Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79930?usp=email )
Change subject: mb/google/dedede: Add initial fw_config configuration setting ......................................................................
Patch Set 6: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79930/comment/38518796_30f96811 : PS4, Line 7: Initial fw_config configuration setting
Please make it a statement by using a verb (in imperative mood). Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/79930/comment/f892ac24_c883e2d2 : PS4, Line 9: 1.Describe
Please add a dot after the enumeration number(?).
Done
https://review.coreboot.org/c/coreboot/+/79930/comment/d5bb184a_32963322 : PS4, Line 10: - WIFI_SAR_ID_0 for AW Wi-Fi module AW-CM421NF : - WIFI_SAR_ID_1 for Intel Wi-Fi module AX211NGW
As this belongs to item one, please indent by four spaces.
Done
File src/mainboard/google/dedede/variants/pirika/variant.c:
https://review.coreboot.org/c/coreboot/+/79930/comment/934927b4_2709602e : PS4, Line 14: 0x350000
Where is this number from?
Please refer below link. Thanks. https://partnerissuetracker.corp.google.com/issues/319778219#comment3