Attention is currently required from: Anson Tseng, Karthik Ramasubramanian, Paul Menzel, Shou-Chieh Hsu.
Patch set 6:Code-Review +1
4 comments:
Commit Message:
Patch Set #4, Line 7: Initial fw_config configuration setting
Please make it a statement by using a verb (in imperative mood). Maybe: […]
Done
Patch Set #4, Line 9: 1.Describe
Please add a dot after the enumeration number(?).
Done
- WIFI_SAR_ID_0 for AW Wi-Fi module AW-CM421NF
- WIFI_SAR_ID_1 for Intel Wi-Fi module AX211NGW
As this belongs to item one, please indent by four spaces.
Done
File src/mainboard/google/dedede/variants/pirika/variant.c:
Patch Set #4, Line 14: 0x350000
Where is this number from?
Please refer below link. Thanks.
https://partnerissuetracker.corp.google.com/issues/319778219#comment3
To view, visit change 79930. To unsubscribe, or for help writing mail filters, visit settings.