build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43959 )
Change subject: soc/mediatek/mt8192: Add gpio driver ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... File src/soc/mediatek/mt8192/gpio.c:
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... PS1, Line 20: static void* gpio_find_reg_addr(gpio_t gpio) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... PS1, Line 23: switch(gpio.base & 0x0f) { switch and case should be at the same indent
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/gpi... PS1, Line 23: switch(gpio.base & 0x0f) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/inc... PS1, Line 29: #define PIN(id, name, flag, bit, base, offset, \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/inc... PS1, Line 184: MD_INT2_C2K_UIM1_HOT_PLUG, SCL_6306, ADSP_URXD0, PTA_RXD, SSPM_URXD_AO, DBG_MON_B0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/inc... PS1, Line 214: CONN_MCU_AICE_TMSC, , RES6, RES7), space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/43959/1/src/soc/mediatek/mt8192/inc... PS1, Line 224: PIN(57,MIPI2_D_SCLK, 0, 1, 0x22, 0x80, space required after that ',' (ctx:VxV)